Recent Posts

Pages: 1 ... 8 9 [10]
91
SCI Development Tools / Re: sciAudio - a new way to put sound in your games!
« Last post by Doan Sephim on July 18, 2020, 03:43:24 PM »
Updated Publisher has been uploaded to the Wiki. It may be a while before I have time to update the repo.
So with the update SCIAudio and Installer am I good to proceed with a patch (especially now that the save bug is fixed!) or do I need to wait for the repo? I'm not exactly sure what that is.
92
SCI Syntax Help / Re: Old SCI0 Template Save Bug
« Last post by lskovlun on July 18, 2020, 03:35:06 PM »
It's a clean fix and holy shit that's a sneaky one haha
It's sneaky and goes right back to SCI Studio. That means this is handwritten, not decompiled code. It was rewritten from an ASM block.
93
SCI Syntax Help / Re: Old SCI0 Template Save Bug
« Last post by Kawa on July 18, 2020, 03:14:38 PM »
It's a clean fix and holy shit that's a sneaky one haha
94
SCI Syntax Help / Re: Old SCI0 Template Save Bug
« Last post by Doan Sephim on July 18, 2020, 03:07:37 PM »
Fantastic! I did the suggested change and it seems to work perfectly!

Awesome catch! I wouldn't have seen that in a million years.

Quick question, is there any potential unintended consequences or is this a fairly clean fix. I get that it was an overflow issue, but my comprehension of how and why is not so good.
95
SCI Syntax Help / Re: Old SCI0 Template Save Bug
« Last post by lskovlun on July 18, 2020, 02:37:50 PM »
I found the bug! It is a buffer overflow in the script code.
We have this line:
Code: [Select]
(method (doit strDescription &tmp temp0 temp1 temp2 temp3 [temp4 360] [temp365 20] [temp386 20])
Look closely at the temp4 variable (which contains the description strings and comes just before the index numbers). It is sized as 360 (20*18 words), but this is not quite enough. Eric's authentic file has this define:
Code: [Select]
(define BUFFERSIZE 361) ;(define BUFFERSIZE (+ (* MAXGAMES COMMENTBUFF) 1))If you change the size of that temp4 array to be just a bit larger (361 words), you'll get the intended result.
96
SCI Development Tools / Re: sciAudio - a new way to put sound in your games!
« Last post by Collector on July 17, 2020, 07:22:17 PM »
Updated Publisher has been uploaded to the Wiki. It may be a while before I have time to update the repo.
97
SCI Syntax Help / Re: Old SCI0 Template Save Bug
« Last post by troflip on July 17, 2020, 12:15:39 AM »
I think the thread took a turn and stopped being about the save bug  :P
98
SCI Syntax Help / Re: Old SCI0 Template Save Bug
« Last post by Doan Sephim on July 16, 2020, 10:54:28 PM »
I'm a little confused. It got really technical and I got lost. Did we find a work around using 19 saves instead of 20, or did we figure something else out? Or did we figure nothing out?
99
SCI Syntax Help / Re: Old SCI0 Template Save Bug
« Last post by OmerMor on July 16, 2020, 11:59:11 AM »
Are there any other disassembly blocks left in the templates?

SCI0, SCI01, and SCI11 have no disassembly blocks at all.

SCI10 only has three - in Logger, PolyEdit, and Talker. I can resolve Talker and thus allow for talking portraits. PolyEdit and Logger? Probably not needed.

Attached are all my Logger/PolyEdit/Talker scripts.


100
SCI Syntax Help / Re: Old SCI0 Template Save Bug
« Last post by Kawa on July 15, 2020, 06:09:00 AM »
Very much not needed, yeah, much like most of the development tools. Now, debug tools...
Pages: 1 ... 8 9 [10]

SMF 2.0.14 | SMF © 2017, Simple Machines
Simple Audio Video Embedder

Page created in 0.075 seconds with 17 queries.