Author Topic: SCI Companion V3 - alpha build notes/bugs/feature requests  (Read 168186 times)

0 Members and 2 Guests are viewing this topic.

Offline troflip

Re: SCI Companion V3 - alpha build notes/bugs/feature requests
« Reply #525 on: December 17, 2015, 12:58:48 PM »
Oh, I see the problem. It's a disassembler issue.

Code: [Select]
code_0706:
lsl      local4
ldi      1
eq?     
bnt      code_0404
pushi    #cursor
pushi    1
pushi    1
pushi    2
lsp      param1
[i] ; lat      temp2
lea      @[temp3 temp2][/i]
push   
callk    StrCpy,  4
push   
callk    StrLen,  2

Change the italicized lines I surrounded in i tags above. For Studio syntax, you'll probably want @temp3[temp2] instead (and // for the comment instead of ;, or just delete that line)
That will fix the edit box not updating issue.

The other problem is basically the same, but not as easily fixable as the indexer is not a simple value. And there are actually a number of other cases of this in there. This will probably require a fix in Companion.

Probably it can be fixed with the current Companion by introducing a few more temp variables into the method. How urgent is this?

« Last Edit: December 17, 2015, 01:52:18 PM by troflip »
Check out my website: http://icefallgames.com
Groundhog Day Competition

Offline Cloudee1

Re: SCI Companion V3 - alpha build notes/bugs/feature requests
« Reply #526 on: December 17, 2015, 03:43:55 PM »
Not urgent at all, just a bug I came across.
Halloween Competition Brass Lantern Prop Competition Groundhog Day Competition

Offline MusicallyInspired

Re: SCI Companion V3 - alpha build notes/bugs/feature requests
« Reply #527 on: December 17, 2015, 03:56:45 PM »
Ah, that is annoying. I always hated that you couldn't overwrite save games in AGS. Always preferred the way SCI did it.
Brass Lantern Prop Competition

Offline Kawa

Re: SCI Companion V3 - alpha build notes/bugs/feature requests
« Reply #528 on: December 19, 2015, 07:19:16 PM »
Quote from: Space Quest 4 CD
What's happened? Who was that guy with the overdeveloped hair dryer? Why did you let yourself be talked into jumping into some strange shimmering hole? Why are you talking to yourself? These incredibly intriguing questions will quickly be forgotten with barely an electron stirred in that well-armored orb atop your shoulders.
Space Quest 4's CD version has messages. That's neat. But what about the earlier floppy version?
Quote from: Space Quest 4
What's happened? Who was that guy with the overdeveloped hair dryer? Why did you let yourself be talked into jumping into some strange shimmering hole? Why are you talking to yourself? These incredibly intriguing questions will quickly be forgotten with barel
...oh. Okay, so the problem here is that Companion's text resource editor clips off too-long lines. The rest of the line is most certainly there -- I just checked in-game real quick -- but if I were to edit it...

Naturally, this gets worse in multilingual games.

Obvious difference: the text editor is a grid with in-place editing, while the message editor is two parts, the actual text being a nice multi-line textbox. Perhaps Brian was on to something with Studio's text editor?

Offline Collector

Re: SCI Companion V3 - alpha build notes/bugs/feature requests
« Reply #529 on: December 19, 2015, 07:51:33 PM »
Quote from: Space Quest 4 CD
What's happened? Who was that guy with the overdeveloped hair dryer? Why did you let yourself be talked into jumping into some strange shimmering hole? Why are you talking to yourself? These incredibly intriguing questions will quickly be forgotten with barely an electron stirred in that well-armored orb atop your shoulders.

As I read your quote it of course played in my head with Gary Owens' voice.
KQII Remake Pic

Offline Kawa

Re: SCI Companion V3 - alpha build notes/bugs/feature requests
« Reply #530 on: December 19, 2015, 07:59:51 PM »
As I read your quote it of course played in my head with Gary Owens' voice.
But only the top quote of course!

Offline MusicallyInspired

Re: SCI Companion V3 - alpha build notes/bugs/feature requests
« Reply #531 on: December 19, 2015, 09:29:35 PM »
Is that the 256-character limit again? I ran into that with SCI0 and had to use SCI Studio to get the TEXTs that I wanted. I had thought it was fixed.
Brass Lantern Prop Competition

Offline Kawa

Re: SCI Companion V3 - alpha build notes/bugs/feature requests
« Reply #532 on: December 19, 2015, 10:12:33 PM »
It might well be, I never bothered to count.

Also, if text entries can contain newlines...

Offline troflip

Re: SCI Companion V3 - alpha build notes/bugs/feature requests
« Reply #533 on: December 20, 2015, 01:15:46 AM »
Yes, it's that. It wasn't properly fixed I guess.

Also, if text entries can contain newlines...

What does this mean? When you report bugs, please try to be specific and clear.
Check out my website: http://icefallgames.com
Groundhog Day Competition

Offline MusicallyInspired

Re: SCI Companion V3 - alpha build notes/bugs/feature requests
« Reply #534 on: December 20, 2015, 09:37:47 AM »
They behave just like strings so you can put '/n' there and the game will interpret it as a new line.
Brass Lantern Prop Competition

Offline Kawa

Re: SCI Companion V3 - alpha build notes/bugs/feature requests
« Reply #535 on: December 20, 2015, 10:35:50 AM »
That wasn't a bug report -- only the length limit thing was. In the Message editor, a multi-line entry shows up with "\n" in the overview, but with much clearer and user-friendly actual newlines in the separate edit box. In the Text editor, you have to write the literal "\n" yourself, which is somewhat less user-friendly I think. Same thing with tabs and "\t".

Offline troflip

Re: SCI Companion V3 - alpha build notes/bugs/feature requests
« Reply #536 on: December 20, 2015, 01:05:19 PM »
Even more user-friendly would be to have the text resources created automatically from strings in the code, like Sierra did it.
Check out my website: http://icefallgames.com
Groundhog Day Competition

Offline OmerMor

Re: SCI Companion V3 - alpha build notes/bugs/feature requests
« Reply #537 on: December 20, 2015, 01:39:48 PM »
And even more user-friendly decompiler would reintroduce these strings back into the decompiled scripts whenever possible...  8)

Offline troflip

Re: SCI Companion V3 - alpha build notes/bugs/feature requests
« Reply #538 on: December 20, 2015, 01:52:09 PM »
And even more user-friendly decompiler would reintroduce these strings back into the decompiled scripts whenever possible...  8)

Err, it already does that, at least for calls to procedures named Print.

The problem is, it depends on text resource support in the procedure you're calling, so there's no automatic way to do this... there needs to be a whitelist.

Check out my website: http://icefallgames.com
Groundhog Day Competition

Offline OmerMor

Re: SCI Companion V3 - alpha build notes/bugs/feature requests
« Reply #539 on: December 20, 2015, 04:05:40 PM »
I think supporting reverse message lookup for calls to the Format kernel function would help tremendously.
They are all over.


SMF 2.0.14 | SMF © 2017, Simple Machines
Simple Audio Video Embedder

Page created in 0.105 seconds with 23 queries.