Author Topic: WinAGI 2.1.3 & Original Games: Errors and Warnings  (Read 662 times)

0 Members and 1 Guest are viewing this topic.

Offline pierrelapin

WinAGI 2.1.3 & Original Games: Errors and Warnings
« on: February 03, 2021, 08:57:23 AM »
I have found some minor warnings and errors using the last WINAGI version (2.1.3) with some games:
Two of them are relevant (Mixed Up Mother Goose and Police Quest 1)

Manhunter SanFrancisco, 3.02    7/26/89
03-févr-21: WARNING: Sound215 was skipped because it's VOL file (MH2VOL.6) is missing.
03-févr-21: WARNING: Sound216 was skipped because it's VOL file (MH2VOL.6) is missing.
Compile!

Mixed Up Mother Goose
WINAGI Crash when clicking on Words Editor icon ! (No Words in this game)
Compile!

Police Quest 1, 2.0G     12/3/87 (AGI STUDIO has no problem and the resource is readable)
View.036, error 513 in preview: can't read past end of resource
Compile!

Space Quest 1, 1.1a 1986-11-1 (ok with other downloads but same version, AGI STUDIO can't read the bad version at all)
Logic.099, Error 688 at position 10 in preview mode:  Unable to decode logic (invalid goto position or if/then block
Logic.100, idem at position 197
=> refuse to compile... certainly a corrupted archive (another one works well)

Space Quest 2, 2.0f (2.0A OK and never contains Logic141 & Picture147)
03-févr-21: WARNING: Logic141 was skipped because it's location (131071) in the VOL file(VOL.0) is invalid.
03-févr-21: WARNING: Picture147 was skipped because it's location (196607) in the VOL file(VOL.0) is invalid.
compile!



Offline AGKorson

Re: WinAGI 2.1.3 & Original Games: Errors and Warnings
« Reply #1 on: February 03, 2021, 07:09:47 PM »
Thank you for the bug reports! I wish you were around for the earlier beta tests!

Manhunter SanFrancisco, 3.02    7/26/89
03-févr-21: WARNING: Sound215 was skipped because it's VOL file (MH2VOL.6) is missing.
03-févr-21: WARNING: Sound216 was skipped because it's VOL file (MH2VOL.6) is missing.
Compile!
Warnings are informational only; they don't mean the game is broken or that WinAGI can't work with them. The warnings you see here are fairly common in Sierra Games. When Sierra built the DIR files, they often left old index information in for resources that they were no longer using. It's usually not a problem because none of the logics ever try to load them (at least not in any of the games I've examined). But the pointers are bad, and WinAGI is just informing you that they are there. WinAGI also deletes the bad pointers from the DIR files.

Mixed Up Mother Goose
WINAGI Crash when clicking on Words Editor icon ! (No Words in this game)
Compile!
This is a good catch. The WORDS.TOK file for this game has no words in group 0 (the words that get ignored). Which is fine; they are not required. But the editor expects them there, and when it tries to set up the form with the list of groups, it gets stuck when it can't find group 0. I'll get a fix out for this shortly.

Police Quest 1, 2.0G     12/3/87 (AGI STUDIO has no problem and the resource is readable)
View.036, error 513 in preview: can't read past end of resource
Compile!
Another good catch. This view has an invalid pointer for the View Description; it is set to a value that is past the end of the file.  WinAGI has always treated that as a fatal error, as attempting to load a view description with an invalid pointer can create problems. But for this view, the view description property is never used, so it's not really a problem. I will get a fix out that ignores this error and repairs the pointer automatically.

Space Quest 1, 1.1a 1986-11-1 (ok with other downloads but same version, AGI STUDIO can't read the bad version at all)
Logic.099, Error 688 at position 10 in preview mode:  Unable to decode logic (invalid goto position or if/then block
Logic.100, idem at position 197
=> refuse to compile... certainly a corrupted archive (another one works well)
If there is a bad logic, due to corrupted source VOL files, then WinAGI will correctly refuse to compile it. Maybe I am misunderstanding your comment?

Space Quest 2, 2.0f (2.0A OK and never contains Logic141 & Picture147)
03-févr-21: WARNING: Logic141 was skipped because it's location (131071) in the VOL file(VOL.0) is invalid.
03-févr-21: WARNING: Picture147 was skipped because it's location (196607) in the VOL file(VOL.0) is invalid.
compile!
This is the same as the Manhunter comment. WinAGI is just informing you that the DIR files have bad pointers in them. Most likely they existed at one time during development, but were dropped at some point. Sierra never bothered to update the DIR files. WinAGI automatically removes the invalid pointers when it imports the game.

For each entry, you add "Compile!" at the end. I think you mean that after importing, the game can be successfully recompiled? If the games can be imported and successfully recompiled, I'm not sure what the issue is. Other than the Space Quest corrupted game, are there any that don't compile? That'd be useful information.

If you know of any other significant issues, I'd love to get that information as well. While I don't want to spend a lot of time on the VB6 code, I will make fixes for significant errors.

Thanks again for the information,

Offline pierrelapin

Re: WinAGI 2.1.3 & Original Games: Errors and Warnings
« Reply #2 on: February 04, 2021, 03:26:32 AM »
I preferred give you all the feedbacks, even if some warning are not very relevant.

For Space Quest 1 problem about unreadable logic, it is strange: I have several archives of Space Quest CGA (from different sources), all of them have the same game version, but only one of them is correct. Other ones show a problem with these both logic script on WINAGI, AGI STUDIO and QT STUDIO.
In previous WINAGI version, I had the same logic 99&100 problem with other games... but with this last version the problem remains only for some archives of one game (Space Quest 1). So it does not seem to be a big issue... maybe a corrupted archive which is available on many web sites. But the strange thing: all archives of Space Quest 1 work well with NAGI, SCUMM and original interpreter!

Another thing (I don't know where to put it): I didn't upload my point&click remake of KQ1 and BlackCauldron here cause of copyright... I have modified the source code of a copyright game, so I think it is difficult to share it.
« Last Edit: February 04, 2021, 03:32:51 AM by pierrelapin »

Offline lskovlun

Re: WinAGI 2.1.3 & Original Games: Errors and Warnings
« Reply #3 on: February 04, 2021, 05:59:30 AM »
Space Quest 2, 2.0f (2.0A OK and never contains Logic141 & Picture147)
03-févr-21: WARNING: Logic141 was skipped because it's location (131071) in the VOL file(VOL.0) is invalid.
03-févr-21: WARNING: Picture147 was skipped because it's location (196607) in the VOL file(VOL.0) is invalid.
compile!
Well, both of these offsets have a special form. They are equal to n×216-1 for n=2 and n=3, respectively.
I'd say it's more indicative of a bad DIR file. I have to believe AGKorson when he says this sort of thing is frequent... but the offsets sure are suspicious.


SMF 2.0.14 | SMF © 2017, Simple Machines
Simple Audio Video Embedder

Page created in 0.118 seconds with 23 queries.