Recent Posts

21

AGI Development Tools / Re: The web version of AGILE (https://agi.sierra.games)

« Last post by lance.ewing on April 08, 2024, 12:54:28 PM »

Unfortunately, there are some problems loading the imported games (Fan games load and play fine). Here's a video of the current errors: https://drive.google.com/file/d/13C3JOZBwA99aVaNrpzToXroiP35BO7O2/view?usp=sharing

Hmmm, this looks like it is in the OPFS part of the code. One of the methods I'm using isn't recognised. The saved game OPFS code works though, but that code doesn't use this particular method. It must be a more recent addition. Let me look up the documentation and release notes to see if I can find anything. Will report back later (will probably be tomorrow now).

It is bad news, unfortunately. Safari doesn't yet support the "createWritable" method on a file handle in OPFS. It is showing as not implemented on the MDN page:

https://developer.mozilla.org/en-US/docs/Web/API/FileSystemFileHandle

There is a bug associated with it (see comment 7):

https://bugs.webkit.org/show_bug.cgi?id=231706#c7

I'll have to get my head around OPFS again to see if I can use the approach I used for saved games when storing the game data files. It uses a SyncAccessHandle instead, which is supported by Safari. I avoided that one for the game data files for a reason but I need to work through it again to remember why. Hopefully it was one of these "too hard" decisions rather than "its impossible" cases. If it was simply harder than the other approach, then it might still be possible. Hopefully I can get this working then.

22

AGI Development Tools / Re: The web version of AGILE (https://agi.sierra.games)

« Last post by lance.ewing on April 08, 2024, 02:54:59 AM »

I think you were absolutely right about the folder name for the IIgs... it had to be that. Although it did auto add the KQ3 thumbnail which was surprising. Maybe it was because I clicked to add KQ3 to begin with, and duplicated that?

Well, it might be because it got the game ID from the LOGIC resources. If a game sets the game ID, but the detection tables don't have an entry for it, then it uses the game ID that is set in the LOGIC resources. Most original Sierra AGI games set the game ID, and for those that don't (MH1 is the only one, I think), then if it is an AGIV3 game, it uses the prefix of the DIR file. So it will pick up the KQ3 thumbnail due to that. This means that it successfully decoded the resource files, since if it hadn't, you would have got an error message pop up. So an IIgs game must in the most part have the same game data files and resource format. The digitized sound must be getting ignored. Obviously if it is hanging though, something isn't quite the same.

23

AGI Development Tools / Re: The web version of AGILE (https://agi.sierra.games)

« Last post by Charles on April 07, 2024, 10:21:40 PM »

How does it look now? If you don't see a difference, try doing a force refresh of the page. I've changed it to "Nearest" in the code. It was set to Linear before. I'm surprised that I didn't change this already, as this is clearly different from the C# version of AGILE. I think I just got used to it and didn't notice it until you pointed it out. Now that I've changed it to Nearest, it looks a lot more original AGI 

Oh much better. I don't see any need to do anything fancier than that for the classic chunky look. Others tastes may vary, but personally I think at a minimum this nearest neighbour look is better than a simple liner upscale.

And I think you were absolutely right about the folder name for the IIgs... it had to be that. Although it did auto add the KQ3 thumbnail which was surprising. Maybe it was because I clicked to add KQ3 to begin with, and duplicated that?

24

AGI Development Tools / Re: The web version of AGILE (https://agi.sierra.games)

« Last post by doomlazer on April 07, 2024, 07:06:34 PM »

That's great news! Thanks for confirming. Did you do the same reset before the previous tests? Just wondering if it really was the appending to the dom that made it work. I think I will leave it in there in any case, as it doesn't hurt, and can only help, really. It's not visible.

I hadn't reset the history before. When the console logging was added it only took a page refresh, so I had normally been refreshing and deleting the stored website data. I tried refreshing after this most recent change and it still wasn't working. Since attaching to the DOM was kind of the last thing to try, I reset the history and it started importing the games.

Let me know when you make some changes and I'll try it again.

25

AGI Development Tools / Re: The web version of AGILE (https://agi.sierra.games)

« Last post by lance.ewing on April 07, 2024, 06:43:48 PM »

I only played around for a couple minutes so haven't really put it through its paces... running Firefox in Windows 10, so not really an edge-case scenario. The only things I noticed off the bat i was curious about: how much control do you have over the filters/scalers?  It looks like a simple bilinear upscale, which is really blurry... my personal preference is a nearest-neighbor overscale, then bilinear to down-sample to the desired size.

How does it look now? If you don't see a difference, try doing a force refresh of the page. I've changed it to "Nearest" in the code. It was set to Linear before. I'm surprised that I didn't change this already, as this is clearly different from the C# version of AGILE. I think I just got used to it and didn't notice it until you pointed it out. Now that I've changed it to Nearest, it looks a lot more original AGI 

I didn't do the overscale and down-sample approach that you mentioned. All I did was change the filter it was already using from Linear to Nearest. Does it look good enough? Or do you think it needs the approach you mentioned? For all I know, the framework might be doing what you suggested under the hood, but not sure.

26

AGI Development Tools / Re: The web version of AGILE (https://agi.sierra.games)

« Last post by lance.ewing on April 07, 2024, 06:36:22 PM »

I completely reset the browsers on both the desktop and iPhone and it does import games now!

That's great news! Thanks for confirming. Did you do the same reset before the previous tests? Just wondering if it really was the appending to the dom that made it work. I think I will leave it in there in any case, as it doesn't hurt, and can only help, really. It's not visible.

Unfortunately, there are some problems loading the imported games (Fan games load and play fine). Here's a video of the current errors: https://drive.google.com/file/d/13C3JOZBwA99aVaNrpzToXroiP35BO7O2/view?usp=sharing

Hmmm, this looks like it is in the OPFS part of the code. One of the methods I'm using isn't recognised. The saved game OPFS code works though, but that code doesn't use this particular method. It must be a more recent addition. Let me look up the documentation and release notes to see if I can find anything. Will report back later (will probably be tomorrow now).

I'm happy to keep testing, but please don't feel like you need to support Safari because of me.

You're actually doing me a big favour. I don't have easy access to testing on iPhone, iPad and Macbook myself, and I am quite keen for it to work on those platforms.

I have noticed that it now works on the Mobile version of Firefox, which it wasn't previously. I think that might have been from one of the earlier changes though, probably the security headers change.

27

AGI Development Tools / Re: The web version of AGILE (https://agi.sierra.games)

« Last post by doomlazer on April 07, 2024, 06:05:53 PM »

I completely reset the browsers on both the desktop and iPhone and it does import games now!

Unfortunately, there are some problems loading the imported games (Fan games load and play fine). Here's a video of the current errors: https://drive.google.com/file/d/13C3JOZBwA99aVaNrpzToXroiP35BO7O2/view?usp=sharing

I'm happy to keep testing, but please don't feel like you need to support Safari because of me.

28

AGI Development Tools / Re: The web version of AGILE (https://agi.sierra.games)

« Last post by lance.ewing on April 07, 2024, 05:25:51 PM »

@doomlazer, can you give it another try now? The code now appends the input element to the dom. I couldn't see any visual difference, despite the fact that the file input element is now in the dom. It has added it into an iframe, which is where this Javascript is running (something to do with how libgdx sets up the web page), so I'm a little worried about whether this will actually work, but let's give it a go. If it doesn't work, then I can see if there is a way to get the input element added to the top level web page instead.

29

AGI Development Tools / Re: The web version of AGILE (https://agi.sierra.games)

« Last post by doomlazer on April 07, 2024, 05:06:27 PM »

I'm a bit worried about a recent comment on the stackoverflow page (https://stackoverflow.com/questions/47664777/javascript-file-input-onchange-not-working-ios-safari-only#comment-137356332) from January 2024 where someone claims that in iOS 17.3 nothing works (addEventListener & append to dom).

Yeah, that doesn't bode well, does it. It's a shame because everything else seems to work fine on Safari besides import.

30

AGI Development Tools / Re: The web version of AGILE (https://agi.sierra.games)

« Last post by lance.ewing on April 07, 2024, 04:43:12 PM »

Instead of using an event listener for "change" in my project I do:

Code: [Select]

input.onchange = e => {
while you've got:

Code: [Select]

fileInputElem.addEventListener("change", function(event) {
I only use the eventlistener for "load" on the FileReader.

Sorry, in my last post, I hadn't seen your recent edit to your post. I've actually tried both approaches to registering the change event listener. The original code that you tried the first time was using the input.onchange approach that your project code is also using. That obviously didn't work for AGILE, and the stackoverflow page below mentions people that were having the same issue with the input.onchange approach not working:

https://stackoverflow.com/questions/47664777/javascript-file-input-onchange-not-working-ios-safari-only

A few of the answers and comments suggest that changing the "onchange" to use addEventListener instead fixed the problem for them, but that doesn't seem to have worked for AGILE. Neither the "onchange" approach nor the addEventListener approach have worked.

I'll try the append to dom approach to see if that works.