SCI Companion V3 - alpha build notes/bugs/feature requests

[Kawa]

Haha what the hell

[Collector]

It would be nice if SCI Companion could support these games natively, but until then renaming the files is a good workaround.

If you mean to open games I agree. If by creating games don't forget that there is no template game beyond 1.1.

[Collector]

Wait what?!

Edit: can confirm, LSL7 doesn't seem to work at all resource-wise, GK2 works for graphics.

Don't forget that LSL7 is an SCI3 game.

[Collector]

How does the naming scheme work? Like, why does the master resource map have a number?

That must be why the GK2 scripts and such were just plain missing -- they'd be listed in RESMAP.001, while I looked in RESMAP.000

If your game has been concatenated with UniSCI then the map file will be named "RESMAP.000"

[Collector]

How does the naming scheme work? Like, why does the master resource map have a number?

That must be why the GK2 scripts and such were just plain missing -- they'd be listed in RESMAP.001, while I looked in RESMAP.000

Actually, they hide in RESSCI.PAT (the corresponding map being RESMAP.PAT) 
EDIT:  And to answer troflip's question, there is one per CD, and an additional one to copy to the hard drive.
EDITEDIT And .AUD and .SFX volumes too.

Seems like the RESOURCE.AUD and RESOURCE.SFX files are usually the same across all discs.

[OmerMor]

It would be nice if SCI Companion could support these games natively, but until then renaming the files is a good workaround.

If you mean to open games I agree. If by creating games don't forget that there is no template game beyond 1.1.

Of course. My main aim was decompilation.
Regarding the template - I have Sierra's system scripts circa 1995 that I could possibly share eventually. When SCI Companion would be able to handle all the resource types from that era we could use that.

[MusicallyInspired]

It would be nice if SCI Companion could support these games natively, but until then renaming the files is a good workaround.

If you mean to open games I agree. If by creating games don't forget that there is no template game beyond 1.1.

Of course. My main aim was decompilation.
Regarding the template - I have Sierra's system scripts circa 1995 that I could possibly share eventually. When SCI Companion would be able to handle all the resource types from that era we could use that.

[Collector]

Fantastic!

[OmerMor]

Some SCI games (e.g. GK1 CD) have their patched scripts located inside a PATCHES subfolder.
ScummVm is already scanning this folder:
https://github.com/scummvm/scummvm/blob/master/engines/sci/sci.cpp#L159

I believe SCI Companion should do that same.

[lskovlun]

https://github.com/scummvm/scummvm/blob/master/engines/sci/sci.cpp#L159
I believe SCI Companion should do that same.

But as the comment in that code says, doing it unconditionally is not unproblematic. Additional problems might arise in Companion when saving resource volumes (which is a moot point for ScummVM).

[troflip]

I thought the patches folder was listed in resource.cfg.

[Collector]

I thought the patches folder was listed in resource.cfg.

It is, at least starting with around SCI1.1. I would have to check what interp that flag first appears.

[Charles]

https://github.com/scummvm/scummvm/blob/master/engines/sci/sci.cpp#L159
I believe SCI Companion should do that same.

But as the comment in that code says, doing it unconditionally is not unproblematic. Additional problems might arise in Companion when saving resource volumes (which is a moot point for ScummVM).

(for the lazy):

Code: [Select]

// Add the patches directory, except for KQ6CD; The patches folder in some versions of KQ6CD
// is for the demo of Phantasmagoria, included in the disk

That used to really bug me way back when, when they'd make compilation discs or what have you... they'd just throw all the files into the same root together.  I remember that in the QFG Anthology disc... All the games would be in nice little sub-folders, except QFG4CD would just be all there in the root, with it's own subfolders intermixed in there.

[MusicallyInspired]

King's Quest Collector's Series too, IIRC. KQ5w and KQ6w would be annoyingly all clumped together in various ways on disc 2. Plus it didn't include the GITT redbook audio track so the game throws up an error at the end.

[OmerMor]

I thought the patches folder was listed in resource.cfg.

It is. You can parse it if you don't mind the extra work.
Of course, we can workaround this by copying the patches to the root folder. But it's an easy thing to miss when you decompile a game (csnover from scummvm was stumped by this, and this is how I learned of this issue).