Author Topic: C# AGILE  (Read 72025 times)

0 Members and 1 Guest are viewing this topic.

Offline vafada

Re: C# AGI Interpreter
« Reply #240 on: November 20, 2022, 09:00:32 PM »
FYI, Gold Rush ver 3.0 doesn't contain  "new.room(125);" line in Logic 129

The code I pasted on https://sciprogramming.com/community/index.php?topic=1796.msg15870#msg15870 is the entire code for Logic 129 in Gold Rush v3.

Offline AGKorson

Re: C# AGI Interpreter
« Reply #241 on: November 21, 2022, 01:13:17 AM »
FYI, Gold Rush ver 3.0 doesn't contain  "new.room(125);" line in Logic 129

The code I pasted on https://sciprogramming.com/community/index.php?topic=1796.msg15870#msg15870 is the entire code for Logic 129 in Gold Rush v3.
Which confirms what I said about how to skip the copy protection. They made the exact same change.

Offline lance.ewing

Re: C# AGI Interpreter
« Reply #242 on: November 21, 2022, 01:29:23 AM »
Which confirms what I said about how to skip the copy protection. They made the exact same change.

I've just made the change you suggested to AGILE's GR patch and confirmed that it works. I have pushed the change to my repo.
« Last Edit: November 21, 2022, 05:58:27 AM by lance.ewing »

Offline Collector

Re: C# AGI Interpreter
« Reply #243 on: November 21, 2022, 07:16:46 PM »
Getting an index out of range exception with the KQ4 demo at line 206

foreach (Resource sound in volume.Sounds) Sounds[sound.Index] = (Sound)sound;

in the GameState class.

I am also getting a few unrecognized games with several versions of KQ4. Need to add the hashes for these versions. One thing that I borrowed from SVM for my Sierra Version tool was to copy the hash to the clipboard of any unrecognized game to add to the game lookup table. I'll look into it when I get a little more time. Without looking I assume that you are getting the hash from the LOGDIR?
KQII Remake Pic

Offline lance.ewing

Re: C# AGI Interpreter
« Reply #244 on: November 21, 2022, 07:26:20 PM »
Yes, the LOGDIR for the V2 games and the DIR file for the V3 games.

Which versions of KQ4 are not recognised? Are they recognised by scummvm? I assume not, as I copied all the md5 values from scummvm, so it should have all the PC games recognised by scummvm.



Offline Collector

Re: C# AGI Interpreter
« Reply #245 on: November 21, 2022, 08:24:26 PM »
I didn't realize that you had added the pathc game option to the options form and the default is false, so it was not skipping the manual check. Turns out that there was only one unrecognized game, King's Quest 4 v2.2 int3.002.086 (5.25"). I'll add the hash to the gameDefinitions when I get a little more time in a couple of days.

I did a pull request. It included some missed null checks
KQII Remake Pic

Offline lance.ewing

Re: C# AGI Interpreter
« Reply #246 on: November 22, 2022, 03:32:02 AM »
Yes, @vafada added the option to the options form for patching. Works quite well from the testing I did.

I have merged your pull request.

Offline Kawa

Re: C# AGI Interpreter
« Reply #247 on: November 24, 2022, 02:07:47 PM »
Regarding the folder browser:

https://github.com/dotnet/winforms/pull/57

Offline lance.ewing

Re: C# AGI Interpreter
« Reply #248 on: November 25, 2022, 06:13:32 PM »
Thanks, I'll take a look at that when I get a free moment, maybe tomorrow. Tbh, I've got quite used to the current folder browser dialog, from having used it so much by now, but I'll implement the alternative on a feature branch to create a build that people can compare, and then maybe we can hold a short poll to see what people think.

Offline Collector

Re: C# AGI Interpreter
« Reply #249 on: November 26, 2022, 07:27:24 AM »
I like what we have now. Simple and straight forward and works every time.
KQII Remake Pic

Offline vafada

Re: C# AGI Interpreter
« Reply #250 on: November 26, 2022, 08:09:38 AM »
@lance.ewing not sure if you have been monitoring the git repo. but i posted a bug for GR rendering.

Looks like an AGILibrary.dll bug so i can't help fix.

https://github.com/lanceewing/agile/issues/64

Also any chance you'll open source AGI Library?

Offline lance.ewing

Re: C# AGI Interpreter
« Reply #251 on: November 26, 2022, 02:25:05 PM »
@lance.ewing not sure if you have been monitoring the git repo. but i posted a bug for GR rendering.

Looks like an AGILibrary.dll bug so i can't help fix.

https://github.com/lanceewing/agile/issues/64

Yes, I saw that. Haven't had a chance to take a look at it yet.

Also any chance you'll open source AGI Library?

I'm building the AGI Library from a fork of @Collector's repo in bitbucket, where it is a sub-project of the "AGI-SCI Developer" repo. So I didn't want to create a different home for that but treat bitbucket as the "master" location, so that the "AGI-SCI Developer" would get the benefit of any changes I make. The repo is private, as @Collector's repo is private, but I can add you as a user. There is a 5 user limit for free private repos on bitbucket, and so far there are only 4 users that have been added: @Collector, @AGKorson, Peter Kelly and myself. It would make sense for you to also be added. So if you have a bitbucket user, let me know and I'll search for you to add your user to the project.

@Collector, at some point I will request my AGI Library changes to be merged back to your repo.

Offline vafada

Re: C# AGI Interpreter
« Reply #252 on: November 26, 2022, 03:18:28 PM »

Offline lance.ewing

Re: C# AGI Interpreter
« Reply #253 on: November 26, 2022, 07:26:28 PM »
It appears that I'll need your email address in order to invite you. PM it to me if you don't want it to be publicly visible in these forums.

Offline lance.ewing

Re: C# AGI Interpreter
« Reply #254 on: November 26, 2022, 10:17:37 PM »
@vafada, something seems to have changed in bitbucket with adding users. I don't recall it being so hard. I have sent you an invite to a new group I created, as that was the only way I could see to invite someone. I didn't previously have a group defined. Perhaps once you accept the invite, I might be able to add you specifically to the repo.


SMF 2.0.19 | SMF © 2021, Simple Machines
Simple Audio Video Embedder

Page created in 0.052 seconds with 22 queries.