C# AGILE

[lance.ewing]

@lance.ewing not sure if you have been monitoring the git repo. but i posted a bug for GR rendering.

Looks like an AGILibrary.dll bug so i can't help fix.

https://github.com/lanceewing/agile/issues/64

I have found the cause of the bug, and even though I didn't directly write the picture part of the AGI Library, I suspect that it is based on PICEDIT, which was in turn based on SHOWPIC from around 1997. The same bug is in those, so I suspect I may be the ultimate cause of this bug 

I am just about to fix it. Will report back here when it is done.

[lance.ewing]

This fix for the GR picture bug is now pushed to my repo.

[vafada]

@vafada, something seems to have changed in bitbucket with adding users. I don't recall it being so hard. I have sent you an invite to a new group I created, as that was the only way I could see to invite someone. I didn't previously have a group defined. Perhaps once you accept the invite, I might be able to add you specifically to the repo.

I accepted the invite... but I can't see any repo

[Collector]

I have been thinking about splitting out the SCI part of Developer since it is unlikely that the SCI part will ever be finished and the AGI part is closer to usability with the further development of the library. I could then move the AGI project over to GitHub if there would be any interest.

[lance.ewing]

I accepted the invite... but I can't see any repo

I finally found the option to invite you to the repo. That is what I was looking for in the first place, but could only spot the invite to the group, and I can see that you are now in the group.

You should now have the invite for the repo.

[lance.ewing]

I have been thinking about splitting out the SCI part of Developer since it is unlikely that the SCI part will ever be finished and the AGI part is closer to usability with the further development of the library. I could then move the AGI project over to GitHub if there would be any interest.

Yeah, that sounds like a really good idea to me, both the splitting out of the AGI parts (which contains the AGI Library), and also moving it into github.

I think I should probably send you a pull request of my AGILibrary changes before you start on the split and move though. I'll get back to you later on when I think I have a pull request ready. There is an old version of AGILE in my bitbucket repo, which it might make sense if I remove before creating the pull request, since we already have that (AGILE) in github, and besides, that AGILE code is now quite old.

[lance.ewing]

I think I should probably send you a pull request of my AGILibrary changes before you start on the split and move though. I'll get back to you later on when I think I have a pull request ready. There is an old version of AGILE in my bitbucket repo, which it might make sense if I remove before creating the pull request, since we already have that (AGILE) in github, and besides, that AGILE code is now quite old.

@Collector, this is now done and I've sent you a pull request.

[vafada]

I have been thinking about splitting out the SCI part of Developer since it is unlikely that the SCI part will ever be finished and the AGI part is closer to usability with the further development of the library. I could then move the AGI project over to GitHub if there would be any interest.

Yes!

[Collector]

I have started to strip out the SCI stuff, but am starting to wonder if I should just start with my latest copy of Visual AGI and add in the features I have in Developer. Developer started as SCI and I think it will have a lot of debris left that will take some effort and time to weed out.

After I get it in better shape I'll create a new repo on GitHub.

[lance.ewing]

I have started to strip out the SCI stuff, but am starting to wonder if I should just start with my latest copy of Visual AGI and add in the features I have in Developer. Developer started as SCI and I think it will have a lot of debris left that will take some effort and time to weed out.

Yeah, that might be a better approach. I assume that the new AGI Library version should still be compatible with the original Visual AGI.

I saw that you have seen my pull request for your bitbucket repo. Have you merged it back yet? Or, given the above, I'm guessing you are planning to start from scratch with the latest copy of Visual AGI and my latest AGI Library version in a new repo?

[Collector]

I have just replaced the library project with your updated one. It seems to work OK, but I have not done any extensive testing. I looked at Visual AGI again and it would be fairly involved to redo all of the features I have in the combined project, so for now I am just cutting out the SCI stuff. I have made some good progress so far. It is also letting me refactor the code. If it becomes too much of a pain I'll take another look at Visual AGI. I won't create a new repo until I make some more progress and then I'll send an invite to the two of you when I do.

[Collector]

Don't have time to try to track it down, now, but AGILE does not accept any keyboard input at the start of the 1986 x-mas card.

[vafada]

Don't have time to try to track it down, now, but AGILE does not accept any keyboard input at the start of the 1986 x-mas card.

its crashing AGILibrary on room 13

I assume there is a bug when parsing the logic file in xmas 1986

GetDestinationAddress = 274

but the Dictionary doesn't have key = 274

Code: [Select]

Exception thrown: 'System.Collections.Generic.KeyNotFoundException' in mscorlib.dll
ex: The given key was not present in the dictionary.
System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at AGI.Resource.Logic.JumpAction.GetDestinationActionIndex() in C:\Users\Mark\Downloads\AGILibrary\AGI Library\Resource.cs:line 2857


[lance.ewing]

I haven't had a chance to look in detail yet but I did notice (in WinAGI) that the logic 13 script has a few unusual labels and goto statements. It should be able to handle it but maybe not. Will need to step through the logic decoding to see what is going on. I might get a chance tomorrow.

[lance.ewing]

The other thing I noticed in WinAGI is that this LOGIC has two return statements at the end of it. I suspect that that is probably the issue. It is a conditional branch that is falling over. I think it is jumping to the very end, i.e. the second return statement, but the LOGIC decoding is probably stopping at the first return statement, thinking that that indicates the end. Should be an easy fix.