ERROR debug

[robbo007]

So this is my Timer Manager script in the end. It seemed to cause all types of grief when I tried to have the time state move between rooms and continue where the last room took off.  So have it restarting when moving between rooms giving a single time limit per room.

Code: [Select]

(script# 306)
(include sci.sh)
(include game.sh)
(use Main)
(use Timer)
(use Obj)
(use Controls)

(public
    timerManager 0
)

(local
    gTimeLimit = 300  ; 300 seconds / 5 mins
    gTimerActive
    gDeathScriptPending
    gQueuedScriptRan
)

(instance timerManager of Obj
    (properties)
   
    (method (init)
        ; Only create new timer if none exists or current one expired
        (if (or (not (IsObject gDhcTimer)) (<= (gDhcTimer seconds?) 0))
            (self dispose:)  ; Clean up any existing timer first
            (= gDhcTimer (Timer new:))
            (gDhcTimer setReal: self gTimeLimit)
        else
            ; Just refresh the existing timer
            (gDhcTimer setReal: self (gDhcTimer seconds?))
        )
        (= gTimerActive TRUE)
    )
   
    (method (cue)
        (= gTimerActive FALSE)
        ; Load room scripts only when needed
        (cond
            ((== gRoomNumber 7)
                (if (not (ScriptID 7)) (ScriptID 7)) ; Ensure script is loaded
                (if (IsObject (ScriptID 7 1))
                    (gRoom setScript: (ScriptID 7 1))
                else
                    (self defaultExpiredHandler:)
                )
            )
            ((== gRoomNumber 8)
                (if (not (ScriptID 8)) (ScriptID 8)) ; Ensure script is loaded
                (if (IsObject (ScriptID 8 1))
                    (gRoom setScript: (ScriptID 8 1))
                else
                    (self defaultExpiredHandler:)
                )
            )
            (else
                (self defaultExpiredHandler:)
            )
        )
    )
   
    (method (doit)
        ; Optimized script queue handling
        (if (and (IsObject gDeathScriptPending) (not gQueuedScriptRan))
            (gRoom setScript: gDeathScriptPending)
            (= gQueuedScriptRan TRUE)
            (= gDeathScriptPending 0)
        )
        (super doit:)
    )
   
    (method (defaultExpiredHandler)
        (Print "Timer expired in unexpected room!")
    )
   
    (method (showTimeLeft &tmp secondsLeft)
        (if (not gTimerActive)
            (Print "No active timer.")
            (return)
        )
        (if (IsObject gDhcTimer)
            (= secondsLeft (gDhcTimer seconds?))
            (FormatPrint "Time left: %d:%02d"
                (/ secondsLeft 60)
                (mod secondsLeft 60)
            )
        else
            (Print "Timer error!")
        )
    )
   
    (method (dispose)
        ; More thorough cleanup
        (if (IsObject gDhcTimer)
            (gDhcTimer client: 0)
            (gDhcTimer dispose:)
            (= gDhcTimer 0)
        )
        (= gTimerActive FALSE)
        (= gDeathScriptPending 0)
        (super dispose:)
    )
)

[doomlazer]

Scripts that need to persist between rooms are typically regions so that they don't get unloaded.

[lskovlun]

This is an antipattern:

Code: [Select]

               (if (not (ScriptID 8)) (ScriptID 8)) ; Ensure script is loaded
                (if (IsObject (ScriptID 8 1))
In the first line, the if-expression will never be true, because ScriptID always loads the script.
In the second, it will never be false, for the same reason.

Unless you miscompile that script somehow. Sierra just did:

Code: [Select]

(ScriptID 8)

[robbo007]

This is an antipattern:

Code: [Select]

               (if (not (ScriptID 8)) (ScriptID 8)) ; Ensure script is loaded
                (if (IsObject (ScriptID 8 1))
In the first line, the if-expression will never be true, because ScriptID always loads the script.
In the second, it will never be false, for the same reason.

Unless you miscompile that script somehow. Sierra just did:

Code: [Select]

(ScriptID 8)

ok thanks. I've updated it now