Police Quest 1 VGA

[Kawa]

Yeah but the observed problem here is that the decompiler didn't know those were supposed to be keys.

And what is even up with the ° everywhere? It's so messy, it makes me not want to help.

[hrvg]

For °:
° -> It is a black point (See screenshot)... I do not have this key on my keyboard, sorry.

[Kawa]

Oh, visible whitespace! Okay... don't do that, please. It made your last post horrible.

I do not understand "26°30" in "proc932_2°26°30".

So yeah in context that'd be

Code: [Select]

(Load rsVIEW (proc932_2 197 1971))
(Dmv
view: (proc932_2 197 1971)
x: (proc932_2 26 30)
init:
)(see how nice that looks like that?)

I already said that proc932_2 returns one value or the other, depending on the current language. Because the menu items change in length when translated, their X positions must be adjusted. So this does the following:

• Preload view 197 or 1971, which is the translated version of 197. View 197 has the menu item texts.
• Set the Dmv prop's view to either 197 or 1971.
• Set its X position (horizontal) to either 26 or 30, to make it all fit together.
• Initialize the prop as normal.

[hrvg]

I tried this.
I made Manage decompilation. I checked (ticked) "Select All". Then decompile.
I open rm200.sc file.
I replaced W (87) -> X (88) and w (119) -> x (120).
I wrote this:                     
(== (pEvent message?) (proc932_2 100 120))
(== (pEvent message?) (proc932_2 68 88))
I made Save. I play game. W/w keys are active and not X/x.
I make Compile. I do not have any more mistakes. I play game. W/w keys are active and not X/x.
I make Compile all. I play game. W/w keys are active and not X/x.
I make Rebuild resources. I play game. W/w keys are active and not X/x.
I renamed rm200.sc file -> 200.scr. I play game. The game crashes.
Where is my mistake, please.
PS:
I understood for "26 30". Thank you.

[hrvg]

Ok, I think I found my mistake, sorry. Thank you for your help.

[Kawa]

Your first mistake was to try and play the game without clicking Compile first.
Your last mistake was renaming the source file.

When you tested the change, did you use a savegame? If yes, was that savegame made while already using the computer? Because the savegame includes all the bytecode for the currently-loaded scripts. Regardless, did you actually switch the game from English to... I guess French?

[hrvg]

When you tested the change, did you use a savegame? If yes, was that savegame made while already using the computer? Because the savegame includes all the bytecode for the currently-loaded scripts. Regardless, did you actually switch the game from English to... I guess French?

You are right.
I know this problem of script files. I translated the texts into these files and that have pointers. I lost several hours understanding why the translation did not appear in the game. I thought about pointers. But, it was as you say.

For my error, I did not modify (transalte) 197.v56 and 811.v56 files. Because DMV is difficult to translate. It does not exist in France. And I did my tests on the Deutsch version and I did not translate the 1971.v56. And I did not think that the drawing of the letter (W/w -> X/x) had a role for the active keys. I tried by chance and it worked. I tried with letter (Z/z). And it works.
I thank you for your patience and help.
My brain will be able to rest. 

[Kawa]

You'll notice in the German version, "DMV" is translated to "Wagen". "Car", not  "AKF" ("Abteilung für Kraftfahrzeuge", as in "Department of Motor Vehicles") So why not go with "Voiture"?

[hrvg]

I delete this message because it is not important. Sorry.

[Kawa]

Please learn to format your posts

[hrvg]

No problem with Deutsch version. But useless for me, because I translate English version.
English version.
My tries (tests):
A)
(== (pEvent message?) KEY_s)
(== (pEvent message?) KEY_S)
No error. But  no work
B)
(== (pEvent message?) (proc932_2 100 115))
(== (pEvent message?) (proc932_2 68 83))
I compile. 155 and 156 lines... Error: (rm200.sc) Unknown procedure 'proc932_2' .  Line: 156, col: 40
http://zupimages.net/viewer.php?id=18/45/jrzx.png
C)
(== (pEvent message?) (proc932_2 `d `s))
(== (pEvent message?) (proc932_2 `D `S))
I compile. 155 and 156 lines... Error: (rm200.sc) Unknown procedure 'proc932_2' .  Line: 156, col: 39
D)
(== (pEvent message?) (proc932_2 'd 's))
(== (pEvent message?) (proc932_2 'D 'S))
I compile. 155 and 156 lines... Error: (rm200.sc) Unknown procedure 'proc932_2' .  Line: 156, col: 39
Same error as C). I do not this sign `
E)
Spanish version
(== (pEvent message?) (proc0_20 100 115))
(== (pEvent message?) (proc0_20 68 83))
I compile. 155 and 156 lines... Error: (rm200.sc) Unknown procedure 'proc0_20' .  Line: 155, col: 38
F)
I inserted these Deutsch files in the game that I translate (English version): 200.scr, 197.v56 and 1971.v56.
The game crashes.
I do not understand. Where is my mistake, please?

[Kawa]

The English version doesn't have any of the multilanguage functions. It doesn't have a proc932_2 for you to call. So test A is actually the only one that could work.

I'll notice you didn't say you compiled in test A.


And again, format your posts, please. They're hard to read.

[hrvg]

And again, format your posts, please. They're hard to read.

I am sorry. My English is very bad. I try to write short and simple.

I'll notice you didn't say you compiled in test A.

Yes. I compile and I do not have error. But It does not work.
If I do "Compile all". I have two errors:
Error: (egoActions.sc) signal is a property.  Only one parameter may be supplied.  Line: 65, col: 9
Error: (Sync.sc) Undeclared identifier '--UNKNOWN-PROP-NAME--' .  Line: 133, col: 23
121 scripts compiled.

I will translate 197.v56 and 811.v56 files. Because these files are complex to translate in French.It is not impossible, but I must to find short words with the first letter different for each word.

[Kawa]

So if you hit Compile, you get no error yet it doesn't work...

Do you test this with a saved game? If you do, is this saved game made while already using the computer? Because as before, that'll just restore and use the old code. You'd have to leave that screen and use the computer again to load your edited version that looks for the other keys.

[hrvg]

So if you hit Compile, you get no error yet it doesn't work...

Yes, It does not work.

Do you test this with a saved game? If you do, is this saved game made while already using the computer? Because as before, that'll just restore and use the old code. You'd have to leave that screen and use the computer again to load your edited version that looks for the other keys.

Yes, I know this problem.
That is what I did:
I modified 197.v56 file. I changed the letter D from "DMV" to S (no MV letters). I saw that D letter was used several times for: Driver's ID and Composite Drawing (I have not changed the D letters.)
So, I changed T letter of "Tools" by O. There is only once the active letter O.
http://zupimages.net/viewer.php?id=18/45/yjzt.png

I made "Export as patch file" in game folder. I made "Open game" (resource.map). I opened "rm200.sc".
I modified:
(== (pEvent message?) KEY_d) --> (== (pEvent message?) KEY_s)
(== (pEvent message?) KEY_D) --> (== (pEvent message?) KEY_S)
(== (pEvent message?) KEY_t) --> (== (pEvent message?) KEY_o)
(== (pEvent message?) KEY_T) --> (== (pEvent message?) KEY_O)
I compile and not error.
http://zupimages.net/viewer.php?id=18/45/an1k.png

I click on "Run Game" in SCICompanion.
I click on "Skip it" in game.
I play... I click on S/s or O/o. It does not work.

So, I made "Open game" (resource.map) and I click on "Run Game" in SCICompanion. Or with DosBox 0.74 in my game. Same, It is always D/d and T/t letters, not S/s and O/o.