Author Topic: QFG1VGA - compile, export as patch - fails?  (Read 1202 times)

0 Members and 1 Guest are viewing this topic.

Offline ZvikaZ

QFG1VGA - compile, export as patch - fails?
« on: January 14, 2021, 06:03:57 PM »
Hi.
I've a strange problem...

I'm working now on QFG1VGA.
Tried changing something at some file. Compiling it, it works.
Then exporting as patch, and putting in a clean directory - it behaves badly.
Checked the game both in ScummVM and DosBox, tried using both Phil's SciCompanion, and Kawa's 3.2.30

More details:
The file is chAlloc.sc - room 203 - the hero creation screen.
I tried commenting out lines 584-597 - the second `Display` call at `namePlate.highlight`.
I've worked in a fresh clean directory, and that was the only change.
After compilation, I've opened it in ScummVM, and it was as expected - everything worked, and the commented code wasn't executed.
Then I've exported the patch file to another clean directory.
Now, when opening it in ScummVM, in that room, there are a lot of warnings in ScummVM's console, 'glpyh 99 drawn out of bounds' (and similar). And worse - the screen is drawn incorrectly. There are 'ch' strings instead of the numerical values, and few more glitches.
The commented code wasn't executed, so, at least that bit is OK...

I tried to revert it, and uncommented that code. But it still behaves the same (except, of course, that the previously-commented code is now executed).

Started over, from clean copy. Now, I've exported a patch *before* compilation. That one seems to work.
Done it all over, same bad results.
Comparing the good patch before compilation, and the last patch, after undoing my changes (which supposedly should have been similar patches), the latter is smaller.

Any ideas?
If someone could also check it, it'd be nice. Maybe I've missed something stupid...

Thanks



Offline Kawa

Re: QFG1VGA - compile, export as patch - fails?
« Reply #1 on: January 14, 2021, 06:35:22 PM »
Did you copy only the .scr file or did you include its .hep? I notice you said "ch" appeared specifically and that's the first string literal in 203.hep, as the name of an object ("chAlloc"), so if the script and its heap don't match up anymore that may be a good indicator.

Offline ZvikaZ

Re: QFG1VGA - compile, export as patch - fails?
« Reply #2 on: January 15, 2021, 02:24:29 AM »
No, I didn't include the heap file.
And you're right. Now I've exported it as well, and it's working.  :)

Really thanks!

BTW,
It might be a nice topic for your blog, to explain the script/heap split, and how (and if?) it relates to the memory heap concept.

Offline ZvikaZ

Re: QFG1VGA - compile, export as patch - fails?
« Reply #3 on: January 15, 2021, 05:30:47 AM »
@kawa, thanks to your help, now it's possible to be a Hebrew Hero  :D



Offline Kawa

Re: QFG1VGA - compile, export as patch - fails?
« Reply #4 on: January 15, 2021, 09:11:11 PM »
It might be a nice topic for your blog, to explain the script/heap split, and how (and if?) it relates to the memory heap concept.
Done, I guess.


SMF 2.0.14 | SMF © 2017, Simple Machines
Simple Audio Video Embedder

Page created in 0.127 seconds with 23 queries.