WinAGI: feature request - lower case GameID

[ZvikaZ]

Currently, when changing the GameID from the game's GUI, it insists that it will be upper case.
Why not let me have it lower case, if I prefer?
I can change it from the .wag file, to lower case, and everything works fine.

Motivation:
ScummVM supports (*) detection fallback for unrecognized games, based on their .wag file. It uses GameID field from the .wag file (among other fields). Therefore, if I set it to 'pq1', I can continue working on the game, while changing it, without touching ScummVM detection tables.

(*) That mechanism hasn't been updated for long time, and it's based on old format of the .wag file. I've created a PR (https://github.com/scummvm/scummvm/pull/2766) to support the newer INI format. It'd be nice if you can comment over there

[AGKorson]

Hmm, I guess I could. Every Sierra game I know of uses all upper case for GameID (even though the check in the set.game.id function is in fact case sensitive). It's just one of those long standing traditions I guess.

I assume the ScummVM check is also case-sensitive? Meaning, if you use 'PQ1', ScummVM will think it's the original Sierra version? Why not just use 'PQ1H' or something like that? The GameID property isn't actually linked to the AGI game - you can set it to anything you want despite what the game logics actually use for the set.game.id command.

In the meantime, let look into what it will take to implement lower case GameIDs.

Oh, and I did drop a comment on your pull request. Hope it helps.

[ZvikaZ]

Thanks for the comment in the PR.

Regarding GameID - that's interesting.
It seems I wasn't clear enough - I want the game to be recognized as the original PQ1.

After reading your reply, I understood that I don't understand the situation well enough...
Anyway, as far as I understand now, there are two different things that are called GameID.
There's Sierra's 'GameID' property. And there's ScummVM internal 'gameid'.
You can open your 'scummvm.ini', and see the 'gameid's of the games - they are all lower cases.

The detection mechanism fallback, using .wag file, is setting ScummVM's gameid to be the GameID property from the wag file. That's why I want the GameID to be lower case in WinAGI, so it will be lower case in ScummVM's gameid, and will be recognized as the original PQ1...

[AGKorson]

Ah, I see. I kind of like leaving it all upper case, but I suppose it doesn't really matter. I'll see if I can include this option in the next fix.